use caching in github actions workflows #262
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyma-bot
added
area/ci
friedrichwilken
force-pushed
the
use-caching-in-tests
branch
from
9702d39 to
fd9b4c5
Compare
muralov
reviewed
Dec 19, 2023
muralov
reviewed
Dec 19, 2023
Comment on lines
+29
to
+34
| - name: Cache Binaries | ||
| id: cache-binaries | ||
| uses: actions/cache@v3 | ||
| with: | ||
| path: bin | ||
| key: ${{ runner.os }}-bin |
There was a problem hiding this comment.
it seems the key is always same although binary is built newly. I've read the GH action documentation that the binary is only built only if key is different than previous key. However, here ${{ runner.os }}-bin is the same for the same OS although the code is changed.
Can you clarify this?
muralov
reviewed
Dec 19, 2023
| @@ -32,7 +32,14 @@ jobs: | |||
| - name: Cache Go dependencies | |||
| uses: actions/setup-go@v5 | |||
| with: | |||
| go-version: '1.21' | |||
| go-version-file: "./go.mod" | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes proposed in this pull request:
Related issue(s)